xuefuz commented on a change in pull request #9995: [FLINK-14526][hive] Support
Hive version 1.1.0 and 1.1.1
URL: https://github.com/apache/flink/pull/9995#discussion_r339165826
##########
File path: flink-connectors/flink-connector-hive/pom.xml
##########
@@ -652,6 +667,22 @@ under the License.
<profiles>
<!-- Activate this profile with -Phive-1.2.1 to build and test
against hive-1.2.1 -->
+ <profile>
+ <id>hive-1.1.1</id>
+ <properties>
+ <hive.version>1.1.1</hive.version>
+
<hivemetastore.hadoop.version>2.6.5</hivemetastore.hadoop.version>
+ <hiverunner.version>3.1.1</hiverunner.version>
+ </properties>
+ </profile>
+ <profile>
+ <id>hive-1.1.0</id>
+ <properties>
+ <hive.version>1.1.0</hive.version>
+
<hivemetastore.hadoop.version>2.6.5</hivemetastore.hadoop.version>
+ <hiverunner.version>3.1.1</hiverunner.version>
+ </properties>
+ </profile>
Review comment:
Can we just add one profile, probably for 1.1.1, to reduce the number of
profiles, unless there are significant differences between the two versions?
We didn't add profile for each version we support previously.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
