lirui-apache commented on a change in pull request #9962: [FLINK-14218][table]
support precise function reference in FunctionCatalog
URL: https://github.com/apache/flink/pull/9962#discussion_r339444434
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionLookup.java
##########
@@ -33,15 +34,15 @@
public interface FunctionLookup {
/**
- * Lookup a function by name. The lookup is case insensitive.
+ * Lookup a function by function identifier. The lookup is case
insensitive.
*/
- Optional<Result> lookupFunction(String name);
+ Optional<Result> lookupFunction(FunctionIdentifier name);
Review comment:
rename the argument to `identifier`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
