zhuzhurk commented on a change in pull request #9920: [FLINK-14389][runtime]
Restore task state before restarting tasks in DefaultScheduler
URL: https://github.com/apache/flink/pull/9920#discussion_r339591260
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java
##########
@@ -212,6 +212,13 @@ private Runnable restartTasks(final
Set<ExecutionVertexVersion> executionVertexV
resetForNewExecutionIfInTerminalState(verticesToRestart);
+ try {
+ restoreState(verticesToRestart);
Review comment:
I think both work. But I moved it out because the name
`resetForNewExecutionIfInTerminalState` is a bit deceiving, since we are
restoring state for all verticesToRestart , not only the vertices in terminal
state.
But I'm thinking whether we can change
`resetForNewExecutionIfInTerminalState`. Rather than reset vertices in terminal
state, we should check all these vertices are in terminal state and then do the
reset. Checking failures may indicate a bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
