zhuzhurk commented on a change in pull request #9920: [FLINK-14389][runtime]
Restore task state before restarting tasks in DefaultScheduler
URL: https://github.com/apache/flink/pull/9920#discussion_r339683817
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java
##########
@@ -212,6 +212,13 @@ private Runnable restartTasks(final
Set<ExecutionVertexVersion> executionVertexV
resetForNewExecutionIfInTerminalState(verticesToRestart);
+ try {
+ restoreState(verticesToRestart);
Review comment:
done.
I'd like to keep the restore block directly in
`DefaultScheduler#restartTasks` so that we can return to skip
schedulingStrategy.restartTasks is an error happen in restore. Otherwise we
need to change `resetForNewExecutions` to have an return value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
