[
https://issues.apache.org/jira/browse/FLINK-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961618#comment-16961618
]
Zili Chen commented on FLINK-14499:
-----------------------------------
After a closer look I think that
{{MetricRegistry#getMetricQueryServiceGatewayRpcAddress}} still technically
possibly returns {{null}} because we separate construction and initialization.
However, it is effective non-null after initialization. We can do a runtime
{{#checkNotNull}} in production code to ensure that such address pass to
{{Dispatcher}} and {{TaskManager}} is non-null. For testing code, we can start
a dummy {{MetricQueryService}}.
> MetricRegistry#getMetricQueryServiceGatewayRpcAddress is Nonnull
> ----------------------------------------------------------------
>
> Key: FLINK-14499
> URL: https://issues.apache.org/jira/browse/FLINK-14499
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Metrics
> Reporter: Zili Chen
> Assignee: AT-Fieldless
> Priority: Minor
>
> As codebase moved, I suspect
> {{MetricRegistry#getMetricQueryServiceGatewayRpcAddress}} is now non-null.
> One can try to figure it out and if so, refactor related code a bit.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
