wangyang0918 commented on a change in pull request #10010:
[FLINK-10435][yarn]Client sporadically hangs after Ctrl + C
URL: https://github.com/apache/flink/pull/10010#discussion_r339882058
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -1241,7 +1241,6 @@ private void failSessionDuringDeployment(YarnClient
yarnClient, YarnClientApplic
// call (we don't know if the application has been
deployed when the error occured).
LOG.debug("Error while killing YARN application", e);
}
- yarnClient.stop();
Review comment:
In L525 and L511, it will throw `YarnDeploymentException` and then yarn
client will be stopped in `CliFrontend->runProgram->clusterDescriptor.close()`.
We should not stop yarn client twice.
We create yarn client outside and i think we should always use
`clusterDescriptor.close()` to stop the yarn client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
