zhijiangW commented on a change in pull request #9993: 
[FLINK-14498][runtime]Introduce NetworkBufferPool#isAvailable() for interacting 
with LocalBufferPool.
URL: https://github.com/apache/flink/pull/9993#discussion_r340465694
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java
 ##########
 @@ -208,17 +233,34 @@ private void 
recycleMemorySegments(Collection<MemorySegment> segments, int size)
                synchronized (factoryLock) {
                        numTotalRequiredBuffers -= size;
 
-                       availableMemorySegments.addAll(segments);
-
                        // note: if this fails, we're fine for the buffer pool 
since we already recycled the segments
                        redistributeBuffers();
                }
+
+               internalRecycle(segments);
+       }
+
+       private void internalRecycle(Collection<MemorySegment> segments) {
 
 Review comment:
   internalRecycle -> internalRecycleMemorySegments

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to