zhijiangW commented on a change in pull request #9993:
[FLINK-14498][runtime]Introduce NetworkBufferPool#isAvailable() for interacting
with LocalBufferPool.
URL: https://github.com/apache/flink/pull/9993#discussion_r340984301
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
##########
@@ -247,7 +247,7 @@ private MemorySegment requestMemorySegment(boolean
isBlocking) throws Interrupte
segment = availableMemorySegments.poll();
}
- if (isBlocking && isUnavailable()) {
+ if (availableMemorySegments.isEmpty()) {
Review comment:
Whether to remove the condition of `isBlocking` was also mentioned in
[10029](https://github.com/apache/flink/pull/10029#discussion_r340033249).
I agree to remove this condition now based on the assumption that it would
has trivial impact for input request side. But this change is better to cover
in a separate commit in order to trace the benchmark impact if possible, and
also it is out of this commit scope.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
