GJL commented on a change in pull request #10037: [FLINK-14561] Don't write
FLINK_PLUGINS_DIR env variable to Configuration
URL: https://github.com/apache/flink/pull/10037#discussion_r340531934
##########
File path:
flink-core/src/main/java/org/apache/flink/core/plugin/PluginConfig.java
##########
@@ -55,23 +55,22 @@ private PluginConfig(Optional<Path> pluginsPath, String[]
alwaysParentFirstPatte
public static PluginConfig fromConfiguration(Configuration
configuration) {
return new PluginConfig(
- getPluginsDirPath(configuration),
+ getPluginsDir().map(File::toPath),
CoreOptions.getParentFirstLoaderPatterns(configuration));
}
- private static Optional<Path> getPluginsDirPath(Configuration
configuration) {
- String pluginsDir =
configuration.getString(ConfigConstants.ENV_FLINK_PLUGINS_DIR, null);
- if (pluginsDir == null) {
- LOG.info("Environment variable [{}] is not set",
ConfigConstants.ENV_FLINK_PLUGINS_DIR);
- return Optional.empty();
- }
+ public static Optional<File> getPluginsDir() {
Review comment:
nit: `Path` is considered the more modern API.
https://stackoverflow.com/questions/6903335/java-7-path-vs-file
The code below can be rewritten to:
```
final Path pluginsDirFile = Paths.get(pluginsDir);
if (!Files.isDirectory(pluginsDirFile)) {
```
Other places would need to be rewritten, however. Therefore, I am not
insisting on a change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
