GJL commented on a change in pull request #10037: [FLINK-14561] Don't write
FLINK_PLUGINS_DIR env variable to Configuration
URL: https://github.com/apache/flink/pull/10037#discussion_r340535513
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/FlinkDistributionOverlay.java
##########
@@ -57,9 +59,9 @@
final File flinkBinPath;
final File flinkConfPath;
final File flinkLibPath;
- final File flinkPluginsPath;
+ final Optional<File> flinkPluginsPath;
- public FlinkDistributionOverlay(File flinkBinPath, File flinkConfPath,
File flinkLibPath, File flinkPluginsPath) {
+ public FlinkDistributionOverlay(File flinkBinPath, File flinkConfPath,
File flinkLibPath, Optional<File> flinkPluginsPath) {
Review comment:
https://flink.apache.org/contributing/code-style-and-quality-java.html#java-optional
> Do not use Optional as a function argument, instead either overload the
method or use the Builder pattern for the set of function arguments.
> Note: an Optional argument can be allowed in a private helper
method if you believe that it simplifies the >code (example).
> Do not use Optional for class fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
