[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962929#comment-16962929
]
Jingsong Lee edited comment on FLINK-13702 at 10/30/19 11:06 AM:
-----------------------------------------------------------------
Thanks [~dwysakowicz], nice analysis, you are right.
{{BinaryFormat}} classes are not thread safe now. Like BinaryRow, it is a
mutable class, mutable class is difficult to be thread safe. So at the
beginning, the design was not thread safe.
I think there is another solution: we can invoke
BinaryString.ensureMaterialized to make BinaryString read thread safe (Or
consider adding a fromStringAndMaterialize method to BinaryString) in
BaseMapSerializerTest.getTestData.
was (Author: lzljs3620320):
Thanks [~dwysakowicz], nice analysis, you are right.
{{BinaryFormat}} classes are not thread safe now. Like BinaryRow, it is a
mutable class, mutable class is difficult to be thread safe. So at the
beginning, the design was not thread safe.
I think there is another solution: we can invoke
BinaryString.ensureMaterialized to make BinaryString read thread safe. (Or
consider adding a fromStringAndMaterialize method to BinaryString)
> BaseMapSerializerTest.testDuplicate fails on Travis
> ---------------------------------------------------
>
> Key: FLINK-13702
> URL: https://issues.apache.org/jira/browse/FLINK-13702
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
> Affects Versions: 1.10.0
> Reporter: Till Rohrmann
> Assignee: Dawid Wysakowicz
> Priority: Critical
> Labels: test-stability
>
> The {{BaseMapSerializerTest.testDuplicate}} fails on Travis with an
> {{java.lang.IndexOutOfBoundsException}}.
> https://api.travis-ci.org/v3/job/570973199/log.txt
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
