[
https://issues.apache.org/jira/browse/FLINK-13702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16963982#comment-16963982
]
Dawid Wysakowicz edited comment on FLINK-13702 at 10/31/19 1:40 PM:
--------------------------------------------------------------------
I don't know exactly how the {{JoinedRow}} is used and therefore if the
{{equals/hashCode}} is needed. Correct me if I am wrong but if we remove the
{{equals/hashCode}} from {{BinaryGeneric}}, doesn't it mean that we can no
longer use generic objects in a {{GroupBy}} clause, no? Isn't that a regression?
Edit: Ok I think the answer is that the key selector always uses {{BinaryRow}},
where the {{BinaryGeneric}} is written as bytes. You never compare the objects.
I would be in favor of removing the {{serializer}} from the {{BinaryGeneric}}
then.
was (Author: dawidwys):
I don't know exactly how the {{JoinedRow}} is used and therefore if the
{{equals/hashCode}} is needed. Correct me if I am wrong but if we remove the
{{equals/hashCode}} from {{BinaryGeneric}}, doesn't it mean that we can no
longer use generic objects in a {{GroupBy}} clause, no? Isn't that a regression?
> BaseMapSerializerTest.testDuplicate fails on Travis
> ---------------------------------------------------
>
> Key: FLINK-13702
> URL: https://issues.apache.org/jira/browse/FLINK-13702
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Planner
> Affects Versions: 1.10.0
> Reporter: Till Rohrmann
> Assignee: Dawid Wysakowicz
> Priority: Critical
> Labels: test-stability
>
> The {{BaseMapSerializerTest.testDuplicate}} fails on Travis with an
> {{java.lang.IndexOutOfBoundsException}}.
> https://api.travis-ci.org/v3/job/570973199/log.txt
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
