zhuzhurk commented on a change in pull request #10048:
[FLINK-14462][coordination] Remove JobGraph#allowQueuedScheduling flag because
it is always true
URL: https://github.com/apache/flink/pull/10048#discussion_r340603599
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerIsolatedTasksTest.java
##########
@@ -180,61 +119,14 @@ public void testScheduleQueueing() throws Exception {
testingSlotProvider.getNumberOfAvailableSlots());
}
- @Test
- public void testScheduleWithDyingInstances() throws Exception {
Review comment:
I think this scenario is still valid. Looks to me it's also testing slot
releasing due to TM lost.
Can we keep this case but adjust the checking logics?
Rather than expect a `NoResourceAvailableException` to be thrown, would it
work to expect the request to be not completed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
