zhuzhurk commented on a change in pull request #10048:
[FLINK-14462][coordination] Remove JobGraph#allowQueuedScheduling flag because
it is always true
URL: https://github.com/apache/flink/pull/10048#discussion_r341801351
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java
##########
@@ -632,52 +629,6 @@ public void
testRestartWithEagerSchedulingAndSlotSharing() throws Exception {
}
}
- @Test
- public void testRestartWithSlotSharingAndNotEnoughResources() throws
Exception {
Review comment:
You are right. I missed that slot sharing part.
Given the only slot provider that supports slot sharing is SchedulerImp, it
would be better to take the initial way you suggested, so that the change can
be simpler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
