tillrohrmann commented on a change in pull request #10037: [FLINK-14561] Don't
write FLINK_PLUGINS_DIR env variable to Configuration
URL: https://github.com/apache/flink/pull/10037#discussion_r340615715
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/FlinkDistributionOverlay.java
##########
@@ -75,12 +77,7 @@ public void configure(ContainerSpecification container)
throws IOException {
addPathRecursively(flinkBinPath, TARGET_ROOT, container);
addPathRecursively(flinkConfPath, TARGET_ROOT, container);
addPathRecursively(flinkLibPath, TARGET_ROOT, container);
- if (flinkPluginsPath.isDirectory()) {
- addPathRecursively(flinkPluginsPath, TARGET_ROOT,
container);
- }
- else {
- LOG.warn("The plugins directory '" + flinkPluginsPath +
"' doesn't exist.");
- }
+
flinkPluginsPath.ifPresent(FunctionUtils.uncheckedConsumer(pluginsPath ->
addPathRecursively(pluginsPath, TARGET_ROOT, container)));
Review comment:
The check has been moved to `PluginConfig#getPluginsDir`. Now the assumption
is that `FlinkDistributionOverlay` must be initialized with a existing plugins
directory if `flinkPluginsPath` is not empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
