tillrohrmann commented on a change in pull request #10037: [FLINK-14561] Don't
write FLINK_PLUGINS_DIR env variable to Configuration
URL: https://github.com/apache/flink/pull/10037#discussion_r340619246
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/FlinkDistributionOverlay.java
##########
@@ -57,9 +59,9 @@
final File flinkBinPath;
final File flinkConfPath;
final File flinkLibPath;
- final File flinkPluginsPath;
+ final Optional<File> flinkPluginsPath;
- public FlinkDistributionOverlay(File flinkBinPath, File flinkConfPath,
File flinkLibPath, File flinkPluginsPath) {
+ public FlinkDistributionOverlay(File flinkBinPath, File flinkConfPath,
File flinkLibPath, Optional<File> flinkPluginsPath) {
Review comment:
If you insist, then I'll change it to a `@Nullable` parameter. But it won't
change much imo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
