wuchong commented on a change in pull request #9994: [FLINK-14322][table-api]
Add watermark information in TableSchema
URL: https://github.com/apache/flink/pull/9994#discussion_r340933268
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java
##########
@@ -343,13 +396,30 @@ public Builder field(String name, TypeInformation<?>
typeInfo) {
return field(name, fromLegacyInfoToDataType(typeInfo));
}
+ /**
+ * Specifies the previously defined field as an event-time
attribute and specifies the watermark strategy.
+ *
+ * @param rowtimeAttribute the field name as a rowtime
attribute, can be a nested field using dot separator.
+ * @param watermarkStrategy the watermark strategy expression
+ */
+ public Builder watermark(String rowtimeAttribute,
ResolvedExpression watermarkStrategy) {
Review comment:
If all the Flink API doesn't require `TableSchema` as parameter/input in the
future, then I think users don't have a reason to create it.
In FLIP-70, we will add computed column information into `TableSchema` too.
The computed expression should also be a resovled expression, because we need
to know the datatype of this field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
