wuchong commented on a change in pull request #9994: [FLINK-14322][table-api]
Add watermark information in TableSchema
URL: https://github.com/apache/flink/pull/9994#discussion_r341482750
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala
##########
@@ -544,6 +545,38 @@ class TableEnvironmentTest extends TableTestBase {
util.addTable[JTuple3[Int, Long, String]]('f0, 'f1.rowtime as 'new, 'f2),
Seq("f0" -> INT, "new" -> ROWTIME, "f2" -> STRING))
}
+
+ @Test
+ def testTableSchemaWithDifferentRowTypes(): Unit = {
+
+ def createInnerRow(innerFieldName: String): TypeInformation[_] = {
+ Types.ROW(
+ Array[String](innerFieldName),
+ Array[TypeInformation[_]](Types.INT()))
+ }
+
+ def createRow(innerFieldName: String): TypeInformation[_] = {
+ Types.ROW(
Review comment:
These 2 methods are inner methods and used by multiple times. If we remove
them, there will be some code duplication here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
