kl0u commented on a change in pull request #9972: [FLINK-14496][client] Exclude
detach flag from ClusterClient
URL: https://github.com/apache/flink/pull/9972#discussion_r341102126
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/ContextEnvironment.java
##########
@@ -87,9 +87,11 @@ public JobExecutionResult execute(String jobName) throws
Exception {
ClientUtils.addJarFiles(jobGraph, this.jarFilesToAttach);
jobGraph.setClasspaths(this.classpathsToAttach);
- lastJobExecutionResult = client
- .submitJob(jobGraph, this.userCodeClassLoader)
- .getJobExecutionResult();
+ if (detached) {
+ lastJobExecutionResult = new
DetachedJobExecutionResult(ClientUtils.submitJob(client, jobGraph).getJobID());
Review comment:
You do not need to re-wrap it in a `DetachedJobExecutionResult`. That is
what the `ClientUtils.submitJob()` returns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
