kl0u commented on a change in pull request #9972: [FLINK-14496][client] Exclude 
detach flag from ClusterClient
URL: https://github.com/apache/flink/pull/9972#discussion_r341162969
 
 

 ##########
 File path: flink-clients/src/main/java/org/apache/flink/client/ClientUtils.java
 ##########
 @@ -95,15 +100,55 @@ public static ClassLoader 
buildUserCodeClassLoader(List<URL> jars, List<URL> cla
                return FlinkUserCodeClassLoaders.parentFirst(urls, parent);
        }
 
+       public static JobExecutionResult submitJob(
+                       ClusterClient<?> client,
+                       JobGraph jobGraph) throws ProgramInvocationException {
+               try {
 
 Review comment:
   You can add the necessary precondition checks like `checkNotNull()` for the 
`client` and the `jobGraph`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to