pnowojski commented on a change in pull request #10009: [FLINK-14304] Avoid
task starvation with mailbox
URL: https://github.com/apache/flink/pull/10009#discussion_r341116077
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailboxImplTest.java
##########
@@ -156,26 +156,26 @@ public void testLifeCycleClose() throws Exception {
try {
taskMailbox.take(DEFAULT_PRIORITY);
Assert.fail();
- } catch (MailboxStateException ignore) {
+ } catch (IllegalStateException ignore) {
Review comment:
Replace those `try`/`assert.fail()`/`catch` with
```
@Rule
public ExpectedException expectedException = ExpectedException.none();
...
@Test
public void foo() {
expectedException.expect(IllegalStateException.class);
}
```
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
