pnowojski commented on a change in pull request #10009: [FLINK-14304] Avoid
task starvation with mailbox
URL: https://github.com/apache/flink/pull/10009#discussion_r341115208
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/Mailbox.java
##########
@@ -37,33 +37,33 @@
*
* @return an optional with either the oldest mail from the mailbox
(head of queue) if the mailbox is not empty or
* an empty optional otherwise.
- * @throws MailboxStateException if mailbox is already closed.
+ * @throws IllegalStateException if mailbox is already closed.
*/
- Optional<Mail> tryTake(int priority) throws MailboxStateException;
+ Optional<Mail> tryTake(int priority) throws IllegalStateException;
Review comment:
remove `throws IllegalStateException;` (and the same in other places)? I
guess there is no point in declaring `RuntimeExceptions` in general and also it
seems strange to declare `IllegalStateException`, as it indicates some bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
