[
https://issues.apache.org/jira/browse/FLINK-14344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964751#comment-16964751
]
Piotr Nowojski commented on FLINK-14344:
----------------------------------------
It would be better to preserve the current semantic, however as I mentioned
before, this is `PublicEvolving` class, so we are allowed to change it. If
barely anyone is using it (only Pravega?) and it looks like pravega doesn't
need this semantic anyway, and if it significantly simplifies our code, I think
we can change the semantic.
So for me there would be two questions:
# how difficult would it be to provide the 2nd semantic? Would dropping the
synchronous hooks support and providing just the 1st semantic be significantly
easier to write/support/maintain? I leave this question up for your judgement.
# is Pravega OK with the second semantic? Could you [~SleePy] ask them about
this?
> Snapshot master hook state asynchronously
> -----------------------------------------
>
> Key: FLINK-14344
> URL: https://issues.apache.org/jira/browse/FLINK-14344
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Checkpointing
> Reporter: Biao Liu
> Assignee: Biao Liu
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we snapshot the master hook state synchronously. As a part of
> reworking threading model of {{CheckpointCoordinator}}, we have to make this
> non-blocking to satisfy the requirement of running in main thread.
> The behavior of snapshotting master hook state is similar to task state
> snapshotting. Master state snapshotting is taken before task state
> snapshotting. Because in master hook, there might be external system
> initialization which task state snapshotting might depend on.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
