azagrebin commented on a change in pull request #10050:
[FLINK-14530][coordination] Capture DataSetID for partitions on TaskExecutor
URL: https://github.com/apache/flink/pull/10050#discussion_r341536440
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -630,8 +631,9 @@ private void setupResultPartitionBookkeeping(
for (ResultPartitionDeploymentDescriptor
resultPartitionDeploymentDescriptor : partitionsRequiringRelease) {
final ResultPartitionID resultPartitionId =
resultPartitionDeploymentDescriptor.getShuffleDescriptor().getResultPartitionID();
+ final IntermediateDataSetID dataSetId =
resultPartitionDeploymentDescriptor.getResultId();
Review comment:
I would rather put this loop into `filterPartitionsRequiringRelease` which
would become:
`Set<ResultPartitionID>
filterAndStartTrackingPartitionsRequiringRelease(...)`
and keep `setupResultPartitionBookkeeping` altogether untouched
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
