azagrebin commented on a change in pull request #10050:
[FLINK-14530][coordination] Capture DataSetID for partitions on TaskExecutor
URL: https://github.com/apache/flink/pull/10050#discussion_r341533665
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -624,15 +626,24 @@ private void setupResultPartitionBookkeeping(
JobID jobId,
Collection<ResultPartitionDeploymentDescriptor>
producedResultPartitions,
CompletableFuture<ExecutionState> terminationFuture) {
- final List<ResultPartitionID> partitionsRequiringRelease =
filterPartitionsRequiringRelease(producedResultPartitions);
+ final Set<ResultPartitionDeploymentDescriptor>
partitionsRequiringRelease =
filterPartitionsRequiringRelease(producedResultPartitions);
Review comment:
in this commit, this is not quite clear why we switch from
`ResultPartitionID` to `ResultPartitionDeploymentDescriptor`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
