tillrohrmann commented on a change in pull request #10048:
[FLINK-14462][coordination] Remove JobGraph#allowQueuedScheduling flag because
it is always true
URL: https://github.com/apache/flink/pull/10048#discussion_r341656391
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java
##########
@@ -632,52 +629,6 @@ public void
testRestartWithEagerSchedulingAndSlotSharing() throws Exception {
}
}
- @Test
- public void testRestartWithSlotSharingAndNotEnoughResources() throws
Exception {
Review comment:
Yes and no I would say. If I'm not mistaken then this test should also fail
if I set `new SimpleSlotProvider(TEST_JOB_ID, parallelism)` because we don't do
proper slot sharing. What one could argue though, is that we don't need to test
recovery with slot sharing if we test restart with no slot sharing and slot
sharing individually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
