AHeise commented on a change in pull request #10084: [FLINK-14382][yarn]
Incorrect handling of FLINK_PLUGINS_DIR on Yarn
URL: https://github.com/apache/flink/pull/10084#discussion_r342770396
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -1556,12 +1572,7 @@ public void run() {
}
}
- void addEnvironmentFoldersToShipFiles(Collection<File>
effectiveShipFiles) {
- addLibFoldersToShipFiles(effectiveShipFiles);
- addPluginsFoldersToShipFiles(effectiveShipFiles);
- }
-
- private void addLibFoldersToShipFiles(Collection<File>
effectiveShipFiles) {
+ void addLibFoldersToShipFiles(Collection<File> effectiveShipFiles) {
Review comment:
Can you please add `@VisibleForTesting`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
