AHeise commented on a change in pull request #10084: [FLINK-14382][yarn] 
Incorrect handling of FLINK_PLUGINS_DIR on Yarn
URL: https://github.com/apache/flink/pull/10084#discussion_r342775567
 
 

 ##########
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
 ##########
 @@ -725,7 +725,10 @@ private ApplicationReport startAppMaster(
                }
 
 Review comment:
   Changes of this commit look good, but I'd like to see a better commit 
message. Please describe what has changed and possibly why.
   
   For example:
   Fixes the Flink plugin mechanism on yarn cluster by shipping only the plugin 
directory instead of adding it to the classpath.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to