JingsongLi commented on a change in pull request #10039: [FLINK-14262][table]
Support referencing function with fully/partially qualified names in SQL
URL: https://github.com/apache/flink/pull/10039#discussion_r342899071
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/catalog/FunctionCatalogOperatorTable.java
##########
@@ -74,7 +84,7 @@ public void lookupOperatorOverloads(
SqlSyntax syntax,
List<SqlOperator> operatorList,
SqlNameMatcher nameMatcher) {
- if (!opName.isSimple()) {
+ if (opName.isStar()) {
Review comment:
We don't know how much SqlSyntax...
If we pass on something we shouldn't, we can return to none. No problem.
But we didn't pass on what we should, which will lead to bugs.
So I think we can keep now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
