JingsongLi commented on a change in pull request #10039: [FLINK-14262][table] Support referencing function with fully/partially qualified names in SQL URL: https://github.com/apache/flink/pull/10039#discussion_r343010615
########## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/functions/utils/ScalarSqlFunction.scala ########## @@ -45,13 +44,13 @@ import scala.collection.JavaConverters._ * @param typeFactory type factory for converting Flink's between Calcite's types */ class ScalarSqlFunction( - name: String, + name: SqlIdentifier, Review comment: After thinking, I agree with you, `FunctionIdentifier` is better. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
