guoweiM commented on a change in pull request #10076: [FLINK-14465][runtime]
Let `StandaloneJobClusterEntrypoint` use user code class loader
URL: https://github.com/apache/flink/pull/10076#discussion_r342920624
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneJobClusterEntryPoint.java
##########
@@ -74,10 +79,20 @@ private StandaloneJobClusterEntryPoint(
}
@Override
- protected DispatcherResourceManagerComponentFactory
createDispatcherResourceManagerComponentFactory(Configuration configuration) {
+ protected DispatcherResourceManagerComponentFactory
createDispatcherResourceManagerComponentFactory(Configuration configuration)
throws IOException {
+ final String flinkHomeDir = System.getenv(ENV_FLINK_HOME_DIR);
Review comment:
>What do you mean with "We could try the ENV_FLINK_USR_LIB_DIR directory
first"?
I want to add an env just like `ENV_FLINK_PLUGINS_DIR` and
`ENV_FLINK_OPT_DIR`
I think you are right. We might make the view of Flink deployment
environment more uniform if we introduce the FLINK_HOME and other directories
could derive from it. So I +1 for your proposal.
>The problem is that the other scripts like flink-daemon.sh don't do this.
Yes. Maybe we could export FLINK_HOME env in config.sh to let all the
scripts to set the FLINK_HOME env. (I am not pretty sure this because scripts
related to pyhton might have a little different. I need to figure out.)
The other situation such as 'YARN/Kubernate' also should export such env.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
