guoweiM commented on a change in pull request #10076: [FLINK-14465][runtime]
Let `StandaloneJobClusterEntrypoint` use user code class loader
URL: https://github.com/apache/flink/pull/10076#discussion_r342914775
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/ClassPathJobGraphRetriever.java
##########
@@ -133,9 +138,18 @@ private String getJobClassNameOrScanClassPath() throws
FlinkException {
}
private String scanClassPathForJobJar() throws IOException {
- LOG.info("Scanning class path for job JAR");
- JarFileWithEntryClass jobJar =
JarManifestParser.findOnlyEntryClass(jarsOnClassPath.get());
-
+ final JarFileWithEntryClass jobJar;
+ if (getUserClassPaths().isEmpty()) {
+ LOG.info("Scanning system class path for job JAR");
+ jobJar =
JarManifestParser.findOnlyEntryClass(jarsOnClassPath.get());
+ } else {
+ LOG.info("Scanning user class path for job JAR");
+ final List<File> userJars = getUserClassPaths()
+ .stream()
+ .map(url -> new File(url.getFile()))
+ .collect(Collectors.toList());
+ jobJar = JarManifestParser.findOnlyEntryClass(userJars);
+ }
Review comment:
> Alternatively, I would remove support for looking for job jars in the
system classpath and rename the retriever to something like
UsrLibJobGraphRetriever.
It's an option. However, there might be some of the situations that the user
himself builds the image. Do you mean that we do not support this situation in
the future?
If we want to support this situation in the future. Another option might be:
1. if the`usrlib` is null we search the system classpath for the entryclass.
2. if the `usrlib` is not null we search the `usrlib` for the entryclass.
>We might wanna change JarManifestParser.findOnlyEntryClass to return an
Optional instead of failing with a NoSuchElementException.
Do you think throwing 'IllegalArgumentException' makes sense?
Sometime we could find more than 1 entryclass. Sometime we could find no
entryclass.
Throwing an IllegalArgumentException could make more clearly what has
happened.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
