kl0u commented on a change in pull request #10069: [FLINK-14593][client] Port
ClusterClient to asynchronous interface version
URL: https://github.com/apache/flink/pull/10069#discussion_r343015112
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java
##########
@@ -41,78 +41,76 @@
*
* @param <T> type of the cluster id
*/
-public abstract class ClusterClient<T> implements AutoCloseable {
-
- /**
- * User overridable hook to close the client, possibly closes internal
services.
- * @deprecated use the {@link #close()} instead. This method stays for
backwards compatibility.
- */
- public void shutdown() throws Exception {
- close();
- }
+public interface ClusterClient<T> extends AutoCloseable {
@Override
- public void close() throws Exception {
+ default void close() throws Exception {
}
/**
- * Requests the {@link JobStatus} of the job with the given {@link
JobID}.
+ * Returns the cluster id identifying the cluster to which the client
is connected.
+ *
+ * @return cluster id of the connected cluster
*/
- public abstract CompletableFuture<JobStatus> getJobStatus(JobID jobId);
+ T getClusterId();
/**
- * Cancels a job identified by the job id.
- * @param jobId the job id
- * @throws Exception In case an error occurred.
+ * Return the Flink configuration object.
+ *
+ * @return The Flink configuration object
*/
- public abstract void cancel(JobID jobId) throws Exception;
+ Configuration getFlinkConfiguration();
+ //region cluster management
Review comment:
Please remove this comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
