kl0u commented on a change in pull request #10069: [FLINK-14593][client] Port
ClusterClient to asynchronous interface version
URL: https://github.com/apache/flink/pull/10069#discussion_r343034823
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/MiniClusterClient.java
##########
@@ -120,7 +135,25 @@ public String stopWithSavepoint(JobID jobId, boolean
advanceToEndOfEventTime, @N
@Override
public String getWebInterfaceURL() {
- return miniCluster.getRestAddress().toString();
+ try {
+ return miniCluster.getRestAddress().get().toString();
+ } catch (InterruptedException | ExecutionException e) {
+ ExceptionUtils.checkInterrupted(e);
+
+ LOG.warn("Could not retrieve the web interface URL for
the cluster.", e);
+ return "Unknown address.";
+ }
+ }
+
+ @Override
+ public void shutDownCluster() {
Review comment:
This seems correct but it is a change of behaviour as previously we were
simply throwing an `UnsupportedOperationException`. Given this, it deserves a
separate JIRA issue and separate commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
