pnowojski commented on a change in pull request #9885:
[FLINK-14344][checkpointing] Snapshots master hook state asynchronously
URL: https://github.com/apache/flink/pull/9885#discussion_r343119379
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/MasterTriggerRestoreHook.java
##########
@@ -95,14 +95,17 @@ default void close() throws Exception {
* the checkpoint metadata under the hooks identifier (see {@link
#getIdentifier()}).
*
* <p>If the action by this hook needs to be executed synchronously,
then this method should
- * directly execute the action synchronously and block until it is
complete. The returned future
- * (if any) would typically be a completed future.
+ * directly execute the action synchronously. The returned future (if
any) would typically be a
+ * completed future.
*
* <p>If the action should be executed asynchronously and only needs to
complete before the
* checkpoint is considered completed, then the method may use the
given executor to execute the
* actual action and would signal its completion by completing the
future. For hooks that do not
* need to store data, the future would be completed with null.
*
+ * <p>Please note that this method should be non-blocking. Any heavy
operation like IO operation
+ * should be executed asynchronously with given executor.
Review comment:
This will require a mention in the release notes, as previously we were
encouraging the calls to be blocking.
Can you add an appropriate reference in the jira ticket? (there is a filed
for release notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
