pnowojski commented on a change in pull request #9885:
[FLINK-14344][checkpointing] Snapshots master hook state asynchronously
URL: https://github.com/apache/flink/pull/9885#discussion_r343065657
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -173,8 +178,16 @@ public int getNumberOfAcknowledgedTasks() {
return operatorStates;
}
- public boolean isFullyAcknowledged() {
- return this.notYetAcknowledgedTasks.isEmpty() && !discarded;
+ public List<MasterState> getMasterStates() {
+ return masterStates;
+ }
+
+ public boolean isMasterStatesFullyAcknowledged() {
+ return notYetAcknowledgedMasterStates.isEmpty() && !discarded;
+ }
+
+ public boolean isTasksFullyAcknowledged() {
Review comment:
nit: `is` -> `are`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
