zentol commented on a change in pull request #10089: [FLINK-12342][yarn] Remove
container requests in order to reduce excess containers
URL: https://github.com/apache/flink/pull/10089#discussion_r343160558
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -370,45 +370,24 @@ public void onContainersCompleted(final
List<ContainerStatus> statuses) {
@Override
public void onContainersAllocated(List<Container> containers) {
runAsync(() -> {
Review comment:
Is there possibly any value in moving part of this method out of the async
block? (removing requests and returning containers)
The idea being that under heavy loadcthe processing of the allocation could
be delayed for quite a while.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
