zentol commented on a change in pull request #10089: [FLINK-12342][yarn] Remove
container requests in order to reduce excess containers
URL: https://github.com/apache/flink/pull/10089#discussion_r343157572
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -419,6 +398,36 @@ public void onContainersAllocated(List<Container>
containers) {
});
}
+ private void startTaskExecutorInContainer(Container requiredContainer) {
Review comment:
wondering whether the `required` prefix makes sense in the context of this
method; I'd tend to say no.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
