xintongsong commented on a change in pull request #9910: [FLINK-14405][runtime]
Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory
setups.
URL: https://github.com/apache/flink/pull/9910#discussion_r343459284
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -529,11 +529,12 @@ public static ResourceProfile
computeSlotResourceProfile(int numOfSlots, long ma
int managedMemoryPerSlotMB = (int)
bytesToMegabytes(managedMemorySize / numOfSlots);
return new ResourceProfile(
Double.MAX_VALUE,
- Integer.MAX_VALUE,
- Integer.MAX_VALUE,
- Integer.MAX_VALUE,
- Integer.MAX_VALUE,
- managedMemoryPerSlotMB,
+ MemorySize.MAX_VALUE,
+ MemorySize.MAX_VALUE,
+ // TODO: before operators separate on-heap/off-heap
managed memory, we use on-heap managed memory to denote total managed memory
+ MemorySize.parse(managedMemoryPerSlotMB + "m"),
Review comment:
Yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
