xintongsong commented on a change in pull request #9910: [FLINK-14405][runtime]
Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory
setups.
URL: https://github.com/apache/flink/pull/9910#discussion_r343462928
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
##########
@@ -416,56 +480,56 @@ public ResourceProfile subtract(ResourceProfile other) {
return new ResourceProfile(
subtractDoublesConsideringInf(cpuCores, other.cpuCores),
Review comment:
There's a `checkArgument` to make sure that `this` is larger than `other`,
if this is what you are concerning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
