wuchong commented on a change in pull request #10096: [FLINK-14623][table-api]
Add computed column information into TableSc…
URL: https://github.com/apache/flink/pull/10096#discussion_r343462975
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java
##########
@@ -170,10 +133,9 @@ public TableSchema copy() {
* e.g. "field1.innerField2"
*/
public Optional<DataType> getFieldDataType(String fieldName) {
- if (fieldNameToType.containsKey(fieldName)) {
- return Optional.of(fieldNameToType.get(fieldName));
- }
- return Optional.empty();
+ return this.columns.stream()
+ .filter(column -> column.getName().equals(fieldName))
+ .findFirst().map(TableColumn::getType);
Review comment:
The javadoc of this method says
```java
* @param fieldName the name of the field. the field name can be a
nested field using a dot separator,
* e.g. "field1.innerField2"
```
which is not correct now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
