wuchong commented on a change in pull request #10096: [FLINK-14623][table-api]
Add computed column information into TableSc…
URL: https://github.com/apache/flink/pull/10096#discussion_r343463120
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java
##########
@@ -346,22 +322,137 @@ public static Builder builder() {
return new Builder();
}
+ //~ Tools
------------------------------------------------------------------
+
+ /**
+ * Tools method to transform arrays of table names and types
+ * into a {@link TableColumn} list.
+ */
+ private static List<TableColumn> createTableColumns(
+ String[] fieldNames,
+ TypeInformation<?>[] fieldTypes) {
+ DataType[] fieldDataTypes =
fromLegacyInfoToDataType(fieldTypes);
+ validateFields(fieldNames, fieldDataTypes);
+ List<TableColumn> columns = new ArrayList<>();
+ for (int i = 0; i < fieldNames.length; i++) {
+ columns.add(TableColumn.of(fieldNames[i],
fieldDataTypes[i]));
+ }
+ return columns;
+ }
+
+ /** Fields sanity check. */
+ private static void validateFields(String[] fieldNames, DataType[]
fieldTypes) {
+ if (fieldNames.length != fieldTypes.length) {
+ throw new ValidationException(
+ "Number of field names and field data types
must be equal.\n" +
+ "Number of names is " +
fieldNames.length +
+ ", number of data types is " +
fieldTypes.length + ".\n" +
+ "List of field names: " +
Arrays.toString(fieldNames) + "\n" +
+ "List of field data types: " +
Arrays.toString(fieldTypes));
+ }
+ // validate and create name to index mapping
+ final Set<String> duplicateNames = new HashSet<>();
+ final Set<String> uniqueNames = new HashSet<>();
+ for (final String fieldName : fieldNames) {
+ // check uniqueness of field names
+ if (uniqueNames.contains(fieldName)) {
+ duplicateNames.add(fieldName);
+ } else {
+ uniqueNames.add(fieldName);
+ }
+ }
+ if (!duplicateNames.isEmpty()) {
+ throw new ValidationException(
+ "Field names must be unique.\n" +
+ "List of duplicate fields: " +
duplicateNames.toString() + "\n" +
+ "List of all fields: " +
Arrays.toString(fieldNames));
+ }
+ }
+
+ /** Watermark specification sanity check. */
+ private static void validateWatermarkSpecs(List<TableColumn> columns,
Review comment:
The `validateWatermarkSpecs` also does the same thing to validate duplicate
field names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
