wuchong commented on a change in pull request #10098:
[FLINK-14326][FLINK-14324][table] Support to apply watermark assigner in planner
URL: https://github.com/apache/flink/pull/10098#discussion_r343526852
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamExecWatermarkAssigner.scala
##########
@@ -126,7 +125,10 @@ class StreamExecWatermarkAssigner(
// 1. redundant watermark definition in DDL
Review comment:
Agree. The previous MiniBatchIntervalTrait design doesn't match the new DDL
watermark any more. Will revisit and refactor this in
[FLINK-14622](https://issues.apache.org/jira/browse/FLINK-14622).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
