wuchong commented on a change in pull request #10098:
[FLINK-14326][FLINK-14324][table] Support to apply watermark assigner in planner
URL: https://github.com/apache/flink/pull/10098#discussion_r343993759
##########
File path:
flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/TableScanTest.xml
##########
@@ -16,36 +16,63 @@ See the License for the specific language governing
permissions and
limitations under the License.
-->
<Root>
+ <TestCase name="testDataStreamScan">
+ <Resource name="sql">
+ <![CDATA[SELECT * FROM DataStreamTable]]>
+
+ </Resource>
+ <Resource name="planBefore">
+ <![CDATA[
+LogicalProject(a=[$0], b=[$1], c=[$2])
++- LogicalTableScan(table=[[default_catalog, default_database,
DataStreamTable]])
+]]>
+
+ </Resource>
+ <Resource name="planAfter">
+ <![CDATA[
+DataStreamScan(table=[[default_catalog, default_database, DataStreamTable]],
fields=[a, b, c])
+]]>
+
+ </Resource>
+ </TestCase>
<TestCase name="testTableSourceScan">
<Resource name="sql">
<![CDATA[SELECT * FROM MyTable]]>
+
</Resource>
<Resource name="planBefore">
<![CDATA[
LogicalProject(a=[$0], b=[$1], c=[$2])
+- LogicalTableScan(table=[[default_catalog, default_database, MyTable,
source: [TestTableSource(a, b, c)]]])
]]>
+
</Resource>
<Resource name="planAfter">
<![CDATA[
TableSourceScan(table=[[default_catalog, default_database, MyTable, source:
[TestTableSource(a, b, c)]]], fields=[a, b, c])
]]>
+
Review comment:
It is related. We added a plan test in `TableScanTest`. So the corresponding
XML will have one more entry. And as I said before, this file should be
re-generated by the framework, not updated manually. These blank lines are
generated by the framework and of course should be in a single commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
