wsry commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r343605312
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -461,16 +461,15 @@ AbstractInvokable getInvokable() {
return invokable;
}
- public StackTraceElement[] getStackTraceOfExecutingThread() {
- final AbstractInvokable invokable = this.invokable;
-
- if (invokable == null) {
- return new StackTraceElement[0];
+ public boolean isAvailableForOutput() {
+ if (invokable == null ||
consumableNotifyingPartitionWriters.length == 0) {
+ return true;
}
-
- return invokable.getExecutingThread()
- .orElse(executingThread)
- .getStackTrace();
+ final CompletableFuture<?>[] outputFutures = new
CompletableFuture[consumableNotifyingPartitionWriters.length];
+ for(int i = 0; i < outputFutures.length; ++i) {
Review comment:
There is only an ```AbstractInvokable``` filed in ```Task```, not
```StreamTask```, if we reuse the code in ```StreamTask```, we may have to make
a type cast and handle other type of ```AbstractInvokable``` except for
```StreamTask```. Maybe the current implementation without code reuse is more
simple and clean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
