xintongsong commented on issue #9928: [FLINK-12122] Add support for spreading slots out across all TaskExecutors URL: https://github.com/apache/flink/pull/9928#issuecomment-551044964 @tillrohrmann Sorry for the late response, and thanks for waiting for me. I still think there could be better ways to expose this feature. But I think that can be a separate concern. And I agree with you that the important thing is we do not block adding new strategies in the future. So +1 from my side for merging this PR. Just to record my two cents on this issue (we don't need to draw a conclusion on this in this PR): - Semantically, disabling `EVENLY_SPREAD_OUT_SLOTS_STRATEGY` does not necessarily mean compactly deploying tasks into some of the TMs. Actually, it's not clearly defined what behaviors should be expected when the option is set to false. Although the current implementation leads to the compact deploying behavior, IMO it's not a commitment that we explicitly make to the users. - I agree with you that if we are not entirely sure that spreading out for standalone and bin packing for Yarn is always the best option, we should allow users to explicitly control this feature. At the meantime, I also think it would be good if we can automatically set this option for the users if that works for the majority of the cases. A possible solution is to make the config option accept three values (true/false/auto). But I would consider that as an optimization and we do not need to do it right now.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
