kl0u opened a new pull request #10115: [FLINK-14630] Re-enable Yarn tests to 
write job manager logs
URL: https://github.com/apache/flink/pull/10115
 
 
   ## What is the purpose of the change
   
   With [FLINK-14502](https://issues.apache.org/jira/browse/FLINK-14502) we 
changed how log property files are being discovered by the 
`YarnClusterDescriptor` and this resulted in Yarn tests not writing their job 
manager log files anymore. This made debugging a lot harder and next to 
impossible. 
   
   This commit fixes this by introducing and exposing the utility method 
`Configuration setLogConfigFileInConfig(...)` in the `FlinkYarnSessionCli` 
which is responsible for discovering the log config file. This method is now 
used directly by the tests to simulate what the CLI does based on user-provided 
input.
   
   ## Verifying this change
   
   Running a test like the `YarnITCase` and seeing the log files being created 
in the `target` dir is sufficient to verify the validity of the change.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to