zentol commented on a change in pull request #10117: [FLINK-14494][docs] Add
ConfigOption type to the documentation generator
URL: https://github.com/apache/flink/pull/10117#discussion_r343840991
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java
##########
@@ -73,11 +73,11 @@
//
------------------------------------------------------------------------
- Class getClazz() {
+ public Class getClazz() {
return clazz;
}
- boolean isList() {
+ public boolean isList() {
Review comment:
Unless we believe that these methods provide value to users I'm actually
inclined to call these via reflection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
