zhijiangW commented on a change in pull request #10083:
[FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs.
URL: https://github.com/apache/flink/pull/10083#discussion_r344001624
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/BackPressureStatsTrackerImpl.java
##########
@@ -250,25 +179,18 @@ public void shutDown() {
}
/**
- * Invalidates the cache (irrespective of clean up interval).
+ * Callback on completed task back pressure request.
*/
- void invalidateOperatorStatsCache() {
- operatorStatsCache.invalidateAll();
- }
-
- /**
- * Callback on completed stack trace sample.
- */
- class StackTraceSampleCompletionCallback implements
BiFunction<StackTraceSample, Throwable, Void> {
+ class BackPressureRequestCompletionCallback implements
BiFunction<BackPressureStats, Throwable, Void> {
private final ExecutionJobVertex vertex;
- public StackTraceSampleCompletionCallback(ExecutionJobVertex
vertex) {
+ public BackPressureRequestCompletionCallback(ExecutionJobVertex
vertex) {
Review comment:
remove `public`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services