zhijiangW commented on a change in pull request #10083: [FLINK-14472][runtime]Implement back-pressure monitor with non-blocking outputs. URL: https://github.com/apache/flink/pull/10083#discussion_r344003590
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/backpressure/OperatorBackPressureStats.java ########## @@ -25,40 +25,36 @@ import static org.apache.flink.util.Preconditions.checkNotNull; /** - * Back pressure statistics of multiple tasks. - * - * <p>Statistics are gathered by sampling stack traces of running tasks. The - * back pressure ratio denotes the ratio of traces indicating back pressure - * to the total number of sampled traces. + * Back pressure statistics of multiple tasks generated by {@link BackPressureStatsTrackerImpl}. */ public class OperatorBackPressureStats implements Serializable { private static final long serialVersionUID = 1L; - /** ID of the corresponding sample. */ - private final int sampleId; + /** ID of the corresponding request. */ + private final int requestId; - /** End time stamp of the corresponding sample. */ + /** End time stamp when all subtask back pressure ratios were collected at the JobManager. */ Review comment: when all the responses of back pressure request were collected in BackPressureRequestCoordinator ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services